mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.
Date Thu, 04 Oct 2018 20:20:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68866/#review209245
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Oct. 4, 2018, 10:02 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68866/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2018, 10:02 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Nicholas Parker.
> 
> 
> Bugs: MESOS-9274
>     https://issues.apache.org/jira/browse/MESOS-9274
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Destruction of the library is not always under our control. For
> example, the JVM can call JNI `finalize()` if the Java scheduler
> nullifies its reference to the V1Mesos library immediately after
> sending `TEARDOWN`. We want to make sure that `TEARDOWN` is sent
> before the Mesos library is destructed.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp 2a5fbd79ac7bad933067cd96e38186849af8edc4

> 
> 
> Diff: https://reviews.apache.org/r/68866/diff/4/
> 
> 
> Testing
> -------
> 
> `make check` on various Linux distro
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message