mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68914: Updated libevent linkage to adhere to best practices.
Date Thu, 04 Oct 2018 16:40:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68914/#review209237
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Oct. 3, 2018, 4:51 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68914/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2018, 4:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9222
>     https://issues.apache.org/jira/browse/MESOS-9222
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> libevent is a combination of libevent_core and libevent_extra. Mesos
> and libprocess do not make use of any libevent_extra functionality.
> 
> Additionally, linking against libevent is against best practices.
> 
> Replaces use of libevent with libevent_core in both libevent.m4 as
> well as the libprocess linkage.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 22b1395ce69f4ac630367427542fa1ad4c88b50b 
>   3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 
> 
> 
> Diff: https://reviews.apache.org/r/68914/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message