mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68913: Updated libevent linkage to adhere to best practices.
Date Thu, 04 Oct 2018 16:40:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68913/#review209236
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Oct. 3, 2018, 4:50 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68913/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2018, 4:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9222
>     https://issues.apache.org/jira/browse/MESOS-9222
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> libevent is a combination of libevent_core and libevent_extra. Mesos
> and libprocess do not make use of any libevent_extra functionality.
> 
> Additionally, linking against libevent is against best practices.
> 
> Replaces use of libevent with libevent_core in libevent.m4,
> FindLIBEVENT.cmake as well as the native Python egg linkage.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/FindLIBEVENT.cmake d6a1e65a2660fa96f50c08298b1e61ac42d85cee 
>   m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 
>   src/python/native_common/ext_modules.py.in df10b5c9131011b0a6b6cb83bceb6d7444aa35eb

> 
> 
> Diff: https://reviews.apache.org/r/68913/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message