mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Urbanovich <sergey.urbanov...@gmail.com>
Subject Review Request 68921: Bring up the loopback interface using `iproute2`.
Date Wed, 03 Oct 2018 22:36:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-9270
    https://issues.apache.org/jira/browse/MESOS-9270


Repository: mesos


Description
-------

The last release of `net-tools` was released in 2001. The tools were
deprecated years ago (see [1], [2], and [3]) and no longer installed
by default in many linux-based operating systems.

Bring up the loopback interface using `ip` from `iproute2` and if it
fails to start fall back on `ifconfig` from `net-tools`.

[1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
[2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
[3] https://lwn.net/Articles/710533/


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ba465522b0de663cf17ff8ca035f6eb32cbd73f1



Diff: https://reviews.apache.org/r/68921/diff/1/


Testing
-------

bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" --gtest_break_on_failure --gtest_repeat=10


Thanks,

Sergey Urbanovich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message