mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.
Date Wed, 03 Oct 2018 20:55:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description
-------

Removed unbundling by default for libevent on macOS when using CMake.


Diffs
-----

  cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba 


Diff: https://reviews.apache.org/r/68919/diff/1/


Testing
-------

macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON  -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
-DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
-DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message