mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63654: Added a `net::socketpair` helper to stout.
Date Mon, 01 Oct 2018 17:36:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63654/
-----------------------------------------------------------

(Updated Oct. 1, 2018, 5:36 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed review feedback.


Bugs: MESOS-8156
    https://issues.apache.org/jira/browse/MESOS-8156


Repository: mesos


Description
-------

Added a `net::socketpair` helper to stout that deals with
automatically setting O_CLOEXEC and disabling SIGPIPE where
necessary.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/socket.hpp 5557394e9ce8e4addc07d328d55274a9d573dfcd

  3rdparty/stout/tests/os/sendfile_tests.cpp e334f489756e6f3352e7b1e84aabb9d40b734138 


Diff: https://reviews.apache.org/r/63654/diff/4/

Changes: https://reviews.apache.org/r/63654/diff/3-4/


Testing
-------

make check (Fedora 26, macOS)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message