mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.
Date Mon, 24 Sep 2018 19:25:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68826/#review208959
-----------------------------------------------------------


Ship it!




LGTM from my limited understanding of python

- Vinod Kone


On Sept. 24, 2018, 6:27 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68826/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2018, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Bugs: MESOS-9253
>     https://issues.apache.org/jira/browse/MESOS-9253
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Because Python is not type-safe, we encountered a bug in the code
> executed on non-Windows platforms that was expecting `output` to be a
> normal Python string instead of a Python byte string (with encoded
> content). To fix this, we now always decode the bytes into a string,
> so that the logic afterwards only has one type to deal with.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py 72b7eb5b9baaf8eaa352b55dad55e62881d87323 
> 
> 
> Diff: https://reviews.apache.org/r/68826/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message