mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68818: Fixed accidental use-after-move.
Date Mon, 24 Sep 2018 18:49:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68818/#review208956
-----------------------------------------------------------


Ship it!




ah, thanks for catching this!

- Meng Zhu


On Sept. 23, 2018, 12:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68818/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2018, 12:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This code was incorrectly accessing an object after it was moved from.
> This patch fixes the typo which lead to that behavior.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 002338a911051df8072c9753c69977841bbac3d1 
> 
> 
> Diff: https://reviews.apache.org/r/68818/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message