mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 68801: Fixed flaky test `SlaveAuthenticationRetryBackoff`.
Date Fri, 21 Sep 2018 19:21:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68801/#review208878
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Sept. 21, 2018, 12:18 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68801/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2018, 12:18 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch dispatches `unmocked_authenticate()` call to the
> slave actor instead of invoking it directly in the test
> thread to avoid race conditions.
> 
> 
> Diffs
> -----
> 
>   src/tests/authentication_tests.cpp 19738101e357e0c7a6ce891df2dcaeffa9b2029f 
> 
> 
> Diff: https://reviews.apache.org/r/68801/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> ran `SlaveAuthenticationRetryBackoff` continuously without failure.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message