mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68768: Fixed disconnection while sending acknowledgment to IOSwitchboard.
Date Fri, 21 Sep 2018 12:52:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68768/#review208853
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 19, 2018, 4:14 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68768/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2018, 4:14 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
>     https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, an HTTP connection to the IOSwitchboard could be garbage
> collected before the agent sent an acknowledgment to the IOSwitchboard
> via this connection. This patch fixes the issue by keeping a reference
> count to the connection in a lambda callback until disconnection
> occurs.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp bf34ef75f8f25cf895d1c4d52923b2d6254f1ecc 
> 
> 
> Diff: https://reviews.apache.org/r/68768/diff/1/
> 
> 
> Testing
> -------
> 
> 1. sudo make check (Fedora 25)
> 2. internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message