mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68784: Fixed broken pipe error in IOSwitchboard.
Date Fri, 21 Sep 2018 12:52:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68784/#review208852
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 21, 2018, 12:12 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68784/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2018, 12:12 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
>     https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previous attempt to fix `HTTP 500` "broken pipe" in review /r/62187/
> was not correct: after IOSwitchboard sends a response to the agent for
> the `ATTACH_CONTAINER_INPUT` call, the socket is closed immediately,
> thus causing the error on the agent. This patch adds a delay after
> IO redirects are finished and before IOSwitchboard forcibly send a
> response.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 5bb21e7c2bf331c44a097ce8f83d8ca7e967332a

> 
> 
> Diff: https://reviews.apache.org/r/68784/diff/2/
> 
> 
> Testing
> -------
> 
> 1. sudo make check (Fedora 25)
> 2. internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message