mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 68711: Added `task ls` command to new CLI.
Date Mon, 17 Sep 2018 10:37:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/
-----------------------------------------------------------

(Updated Sept. 17, 2018, 12:37 p.m.)


Review request for mesos, Eric Chung and Kevin Klues.


Changes
-------

Rebased on refactoring.


Summary (updated)
-----------------

Added `task ls` command to new CLI.


Bugs: MESOS-8795
    https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description (updated)
-------

Added `task ls` command to new CLI.


Diffs (updated)
-----

  src/python/cli_new/lib/cli/agents.py PRE-CREATION 
  src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9

  src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
  src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 


Diff: https://reviews.apache.org/r/68711/diff/3/

Changes: https://reviews.apache.org/r/68711/diff/2-3/


Testing
-------

Tested manually and:
```
(mesos-cli) ?  cli_new (DCOS_OSS-4083) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 5 tests in 9.656s

OK
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message