mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.
Date Fri, 14 Sep 2018 19:40:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68723/#review208646
-----------------------------------------------------------




support/verify-reviews.py
Line 253 (original), 246 (patched)
<https://reviews.apache.org/r/68723/#comment292751>

    Up to your use of it if you just want silence here instead.


- Andrew Schwartzmeyer


On Sept. 14, 2018, 12:39 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68723/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 12:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9232
>     https://issues.apache.org/jira/browse/MESOS-9232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics changed when the ReviewBot scripts were upstreamed; this
> makes the `out_file` parameter optional, writing to stdout if not set.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d 
> 
> 
> Diff: https://reviews.apache.org/r/68723/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with `--skip-verify` on the CLI; argument is no longer required.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message