mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.
Date Fri, 14 Sep 2018 07:39:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68714/#review208618
-----------------------------------------------------------


Ship it!




Makes sense, let's role it out and see if it gets things back on their feet again.

@andschwa @dragoshsch Please check what else was broken by `590a75d0c9d61b0b07f8a3807225c40eb8189a0b`?
You'll also to update `support/mesos-reviewbot.ps1` if it is used.

- Benjamin Bannier


On Sept. 14, 2018, 9:34 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68714/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 9:34 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Dragos Schebesch.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/jenkins/reviewbot.sh 57ae5a347e0b5834510766f2a9a5aa7f33fd21b9 
> 
> 
> Diff: https://reviews.apache.org/r/68714/diff/1/
> 
> 
> Testing
> -------
> 
> None, I don't know how to test this script outside of Jenkins.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message