mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xudong Ni via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68706: Added master failover reregistration progress metrics.
Date Wed, 12 Sep 2018 21:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68706/
-----------------------------------------------------------

(Updated Sept. 12, 2018, 9:42 p.m.)


Review request for mesos, Benjamin Mahler, James Peach, and Jiang Yan Xu.


Bugs: MESOS-9178
    https://issues.apache.org/jira/browse/MESOS-9178


Repository: mesos


Description
-------

When an agent is reregistrated, the time delta from that moment to
the master elected time was saved; In the progress of reregistration,
each data entry represents the registration time delta from master
elected time; The percentile of these data as in this metrics can
represent overall reregistration progress; In case of degradation
towards to the end of reregistration, the high percentile will
reflect it.

Note: These metrics only represent the completed reregistration; It
does not monitor agents were finally marked as unreachable that the
reregistration didn't actually happen, the unreachable agents were
already monitored by existing metrics.


Diffs
-----

  docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 
  src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 
  src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 


Diff: https://reviews.apache.org/r/68706/diff/1/


Testing (updated)
-------

Tested in mmaster with seven reregistration agents:
"master/slaves_reregistration_secs":32.321583104,
"master/slaves_reregistration_secs/count":7,
"master/slaves_reregistration_secs/max":32.321583104,
"master/slaves_reregistration_secs/min":3.35373696,
"master/slaves_reregistration_secs/p50":8.774915072,
"master/slaves_reregistration_secs/p90":30.8676036608,
"master/slaves_reregistration_secs/p95":31.594593382399996,
"master/slaves_reregistration_secs/p99":32.176185159679996,
"master/slaves_reregistration_secs/p999":32.307043309567995,
"master/slaves_reregistration_secs/p9999":32.3201291245568,


Thanks,

Xudong Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message