mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 68414: Made authentication tests independent of wall clock time.
Date Wed, 12 Sep 2018 21:13:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68414/#review208577
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/authentication_tests.cpp
Lines 121-124 (original), 126-128 (patched)
<https://reviews.apache.org/r/68414/#comment292638>

    Do we still need this? The clock is not advanced since the previous `Clock::settle()`,
so we should be able to remove this part.


- Gastón Kleiman


On Aug. 21, 2018, 2:18 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68414/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 2:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch pauses and manipulates the clock for all
> authentication tests. This makes the test less flaky-prone
> and speeds up the test run time.
> 
> 
> Diffs
> -----
> 
>   src/tests/authentication_tests.cpp f7a2cf17cf6154c9c67e405661bba57cf1254845 
> 
> 
> Diff: https://reviews.apache.org/r/68414/diff/2/
> 
> 
> Testing
> -------
> 
> make check, and authentication tests ran continously without failure.
> 
> Authentication test took:
> before: 0m15.282s
> after:  0m6.847s
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message