mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68230: Added `AgentAPITest.LaunchNestedContainerSessionKillTask` test.
Date Wed, 12 Sep 2018 15:01:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68230/#review208560
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/api_tests.cpp
Lines 6670 (patched)
<https://reviews.apache.org/r/68230/#comment292599>

    Kill this line



src/tests/api_tests.cpp
Lines 6679 (patched)
<https://reviews.apache.org/r/68230/#comment292600>

    Kill this line



src/tests/api_tests.cpp
Lines 6714-6721 (patched)
<https://reviews.apache.org/r/68230/#comment292601>

    Instead, you can piggy back on connection success, something like this:
    ```
      EXPECT_CALL(*scheduler, connected(_))
        .WillOnce(v1::scheduler::SendSubscribe(v1::DEFAULT_FRAMEWORK_INFO));
    ```



src/tests/api_tests.cpp
Lines 6752-6753 (patched)
<https://reviews.apache.org/r/68230/#comment292602>

    `MesosTest::defaultTaskResourcesString`



src/tests/api_tests.cpp
Lines 6755 (patched)
<https://reviews.apache.org/r/68230/#comment292603>

    `SLEEP_COMMAND()`



src/tests/api_tests.cpp
Lines 6766-6784 (patched)
<https://reviews.apache.org/r/68230/#comment292607>

    Not yours, but please—for me and my sanity!—let's pull it into a general helper in
`tests/mesos.hpp`. Quick grepping shows there are more instances where this helper can be
applied (can you even maybe fix those in a separate patch?)
    
    https://github.com/apache/mesos/blob/af82f887db535c44b559e0d19cbddfb2dbd6134a/src/tests/master_tests.cpp#L9568-L9586
    https://github.com/apache/mesos/blob/af82f887db535c44b559e0d19cbddfb2dbd6134a/src/tests/scheduler_tests.cpp#L612-L630



src/tests/api_tests.cpp
Lines 6787 (patched)
<https://reviews.apache.org/r/68230/#comment292608>

    Kill this line



src/tests/api_tests.cpp
Lines 6833-6835 (patched)
<https://reviews.apache.org/r/68230/#comment292609>

    Update the comment please!



src/tests/api_tests.cpp
Lines 6843-6854 (patched)
<https://reviews.apache.org/r/68230/#comment292610>

    Does it make sense to make helpers out of these as well?


- Alexander Rukletsov


On Aug. 31, 2018, 1:11 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68230/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2018, 1:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.
> 
> 
> Bugs: MESOS-9131
>     https://issues.apache.org/jira/browse/MESOS-9131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that IOSwitchboard, which holds an open HTTP input
> connection, terminates once IO redirects finish for the corresponding
> nested container.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 6be0dfa28333a15b1650268798046dd5e76717c5 
> 
> 
> Diff: https://reviews.apache.org/r/68230/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message