mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Date Tue, 11 Sep 2018 14:50:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208514
-----------------------------------------------------------


Fix it, then Ship it!




LGTM. I'll fix remaining issues before committing.

Let's please make sure to follow up with updating the arm CI. Could you create an issue for
that?


support/mesos-build/centos-7.dockerfile
Lines 54 (patched)
<https://reviews.apache.org/r/68538/#comment292501>

    No need to `update` here.


- Benjamin Bannier


On Sept. 11, 2018, 12:25 p.m., Robin Gögge wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2018, 12:25 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and
Kevin Klues.
> 
> 
> Bugs: MESOS-8957
>     https://issues.apache.org/jira/browse/MESOS-8957
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
> 
> 
> Diffs
> -----
> 
>   support/mesos-build/centos-7.dockerfile 068f946f8 
>   support/mesos-build/ubuntu-16.04.dockerfile 503b2e370 
> 
> 
> Diff: https://reviews.apache.org/r/68538/diff/5/
> 
> 
> Testing
> -------
> 
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
> 
> 
> Thanks,
> 
> Robin Gögge
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message