mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robin Gögge <r.goe...@outlook.com>
Subject Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Date Tue, 11 Sep 2018 07:08:54 GMT


> On Sept. 10, 2018, 9:07 p.m., Benjamin Bannier wrote:
> > support/mesos-build/ubuntu-16.04-arm.dockerfile
> > Lines 42 (patched)
> > <https://reviews.apache.org/r/68538/diff/4/?file=2087575#file2087575line42>
> >
> >     Is this still needed if we explicitly pull in python36 below?

This is needed to have the `add-apt-repository` command. This is also why the command is failing
for the `support/mesos-tidy/Dockerfile`.


- Robin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208495
-----------------------------------------------------------


On Sept. 10, 2018, 4:36 p.m., Robin Gögge wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2018, 4:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and
Kevin Klues.
> 
> 
> Bugs: MESOS-8957
>     https://issues.apache.org/jira/browse/MESOS-8957
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
> 
> 
> Diffs
> -----
> 
>   support/mesos-build/centos-7.dockerfile 068f946f8 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1 
>   support/mesos-build/ubuntu-16.04.dockerfile 503b2e370 
>   support/mesos-tidy/Dockerfile ea28e4099 
> 
> 
> Diff: https://reviews.apache.org/r/68538/diff/4/
> 
> 
> Testing
> -------
> 
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
> 
> 
> Thanks,
> 
> Robin Gögge
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message