mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Date Mon, 10 Sep 2018 21:07:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208495
-----------------------------------------------------------




support/mesos-build/centos-7.dockerfile
Lines 54-64 (patched)
<https://reviews.apache.org/r/68538/#comment292461>

    Could we instead use the Fedora epel7 repo?
    ```
    yum install https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
    
    yum install python36 python36-devel python36-pip
    ```



support/mesos-build/centos-7.dockerfile
Lines 70 (patched)
<https://reviews.apache.org/r/68538/#comment292457>

    Can we disable pip caching here with `--no-cache-dir`?



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 42 (patched)
<https://reviews.apache.org/r/68538/#comment292463>

    Is this still needed if we explicitly pull in python36 below?



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 57 (patched)
<https://reviews.apache.org/r/68538/#comment292464>

    Looking at the details of this ppa it does only seem to provide `arm64`, `armd64`, and
`armhf`, but not `armv8` used here. It would be nice to confirm whether this works. I checked
this with janisz which should be close to you.



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 59-62 (patched)
<https://reviews.apache.org/r/68538/#comment292460>

    nit: indent by two more spaces.



support/mesos-build/ubuntu-16.04.dockerfile
Lines 42 (patched)
<https://reviews.apache.org/r/68538/#comment292462>

    Is this still needed if we explicitly pull in python36 below?



support/mesos-build/ubuntu-16.04.dockerfile
Lines 57-59 (patched)
<https://reviews.apache.org/r/68538/#comment292454>

    nit: indent by two more spaces.



support/mesos-tidy/Dockerfile
Lines 78-94 (patched)
<https://reviews.apache.org/r/68538/#comment292459>

    These changes seem not required for this image, let's leave it as is to keep it small.
    
    If you want to keep them, you'd need to fix the following error,
    ```
    Step 10 : RUN add-apt-repository -y ppa:deadsnakes/ppa &&     apt-get update &&
    apt-get install -qy     python3.6     python3.6-dev     python3.6-venv &&    
add-apt-repository --remove -y ppa:deadsnakes/ppa &&     apt-get clean &&
    rm -rf /var/lib/apt/lists
     ---> Running in 9680ad7925ea
    /bin/sh: 1: add-apt-repository: not found
    ```
    
    This does not look like a transient error.


- Benjamin Bannier


On Sept. 10, 2018, 6:36 p.m., Robin Gögge wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2018, 6:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and
Kevin Klues.
> 
> 
> Bugs: MESOS-8957
>     https://issues.apache.org/jira/browse/MESOS-8957
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
> 
> 
> Diffs
> -----
> 
>   support/mesos-build/centos-7.dockerfile 068f946f8 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1 
>   support/mesos-build/ubuntu-16.04.dockerfile 503b2e370 
>   support/mesos-tidy/Dockerfile ea28e4099 
> 
> 
> Diff: https://reviews.apache.org/r/68538/diff/4/
> 
> 
> Testing
> -------
> 
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
> 
> 
> Thanks,
> 
> Robin Gögge
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message