mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.
Date Mon, 10 Sep 2018 18:00:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/
-----------------------------------------------------------

(Updated Sept. 10, 2018, 6 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Summary (updated)
-----------------

Fixed broken pipe error in IOSwitchboard.


Repository: mesos


Description (updated)
-------

We force the `ATTACH_CONTAINER_INPUT` request to return a final
response to the client after IO redirects are finished. In this case,
we don't read remaining messages from the `ATTACH_CONTAINER_INPUT`
request. So the agent might send an acknowledgment for the request
before IOSwitchboard has received remaining messages. We need to delay
termination of IOSwitchboard to give it a chance to read the remaining
messages. Otherwise, the agent might get `HTTP 500` "broken pipe" while
attempting to write the final message.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 52b0e521ed1c651c90b3a3df7c4df576288bf400



Diff: https://reviews.apache.org/r/62187/diff/2/

Changes: https://reviews.apache.org/r/62187/diff/1-2/


Testing
-------

internal CI (3x times)


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message