mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Date Mon, 10 Sep 2018 15:35:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208486
-----------------------------------------------------------




support/mesos-build/centos-7.dockerfile
Lines 63 (patched)
<https://reviews.apache.org/r/68538/#comment292437>

    Let's clean after this:
    ```
        yum clean all && \
        rm -rf /var/cache/yum
    ```



support/mesos-build/centos-7.dockerfile
Lines 64 (patched)
<https://reviews.apache.org/r/68538/#comment292438>

    Let's cut here.
    Also: can we use `update-alternatives` instead?



support/mesos-build/centos-7.dockerfile
Lines 66 (patched)
<https://reviews.apache.org/r/68538/#comment292439>

    Let's cut here.



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 62 (patched)
<https://reviews.apache.org/r/68538/#comment292444>

    Let's clean after this:
    ```
        apt-get clean && \
        rm -rf /var/lib/apt/lists
    ```



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 63 (patched)
<https://reviews.apache.org/r/68538/#comment292445>

    Let's cut here.



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 64 (patched)
<https://reviews.apache.org/r/68538/#comment292447>

    Can we use `update-alternatives` instead?



support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 65 (patched)
<https://reviews.apache.org/r/68538/#comment292446>

    Let's cut here.



support/mesos-build/ubuntu-16.04.dockerfile
Lines 59 (patched)
<https://reviews.apache.org/r/68538/#comment292440>

    Let's clean after this:
    ```
        apt-get clean && \
        rm -rf /var/lib/apt/lists
    ```



support/mesos-build/ubuntu-16.04.dockerfile
Lines 60 (patched)
<https://reviews.apache.org/r/68538/#comment292441>

    Let's cut here.



support/mesos-build/ubuntu-16.04.dockerfile
Lines 61 (patched)
<https://reviews.apache.org/r/68538/#comment292442>

    Can we use `update-alternatives` instead?



support/mesos-build/ubuntu-16.04.dockerfile
Lines 62 (patched)
<https://reviews.apache.org/r/68538/#comment292443>

    Let's cut here.


- Armand Grillet


On Sept. 7, 2018, 6:55 p.m., Robin Gögge wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2018, 6:55 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin Klues.
> 
> 
> Bugs: MESOS-8957
>     https://issues.apache.org/jira/browse/MESOS-8957
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
> 
> 
> Diffs
> -----
> 
>   support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161

>   support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8

> 
> 
> Diff: https://reviews.apache.org/r/68538/diff/3/
> 
> 
> Testing
> -------
> 
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
> 
> 
> Thanks,
> 
> Robin Gögge
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message