mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 68662: Avoided double copying of outgoing messages in the master.
Date Fri, 07 Sep 2018 00:00:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/#review208431
-----------------------------------------------------------


Fix it, then Ship it!





src/master/metrics.hpp
Lines 243 (patched)
<https://reviews.apache.org/r/68662/#comment292340>

    This kind message is not sent to v0 schedulers, so we should take it out.


- Gastón Kleiman


On Sept. 6, 2018, 3:39 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68662/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 3:39 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.
> 
> 
> Bugs: MESOS-9213
>     https://issues.apache.org/jira/browse/MESOS-9213
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When framework metrics were introduced, there was an evolve + devolve
> conversion occuring in order to map old style messages to the new
> `scheduler::Event::Type`. This results in copying all outgoing
> messages twice.
> 
> This patch avoids the copying by adding overloads for the old style
> messages.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98 
>   src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301 
>   src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d 
> 
> 
> Diff: https://reviews.apache.org/r/68662/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message