mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68641: Added version check and bundling of libevent within libprocess.
Date Thu, 06 Sep 2018 08:17:09 GMT


> On Sept. 6, 2018, 3:23 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Failed to apply the dependent review: 68640.
> > 
> > Failed command: `python.exe .\support\apply-reviews.py -n -r 68640`
> > 
> > All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2299/mesos-review-68641
> > 
> > Relevant logs:
> > 
> > - [apply-review-68640.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2299/mesos-review-68641/logs/apply-review-68640.log):
> > 
> > ```
> > ?68640.patch:77: trailing whitespace.
> >  
> > 68640.patch:90: space before tab in indent.
> >  	return 1;
> > 68640.patch:92: trailing whitespace.
> >  
> > 68640.patch:95: space before tab in indent.
> >  	if (!b)
> > 68640.patch:96: space before tab in indent.
> >  		return 0;
> > error: missing binary patch data for '3rdparty/libevent-2.0.22-stable.tar.gz'
> > error: binary patch does not apply to '3rdparty/libevent-2.0.22-stable.tar.gz'
> > error: 3rdparty/libevent-2.0.22-stable.tar.gz: patch does not apply
> > ```

@till: Could you upload the binaries as well? See e.g., https://issues.apache.org/jira/browse/MESOS-3906?focusedCommentId=15003432&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15003432
how to accomplish this.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68641/#review208391
-----------------------------------------------------------


On Sept. 6, 2018, 2:32 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68641/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 2:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach.
> 
> 
> Bugs: MESOS-7076
>     https://issues.apache.org/jira/browse/MESOS-7076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added version check and bundling of libevent within libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am f9d9d0609f5c8fed419be83319319e67afc063b7 
>   3rdparty/libprocess/configure.ac e9e2434b7b6fe6c94c28744a86f9412b6302cbe0 
> 
> 
> Diff: https://reviews.apache.org/r/68641/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. Additional testing is ongoing.
CMake updates will follow.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message