mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.
Date Wed, 05 Sep 2018 16:34:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65168/
-----------------------------------------------------------

(Updated Sept. 5, 2018, 4:34 p.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-----------------

Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.


Bugs: MESOS-8545
    https://issues.apache.org/jira/browse/MESOS-8545


Repository: mesos


Description (updated)
-------

Previously, IOSwitchboard process could terminate before all HTTP
responses had been sent to the agent. In the case of
`ATTACH_CONTAINER_INPUT` call, we could drop a final HTTP `200 OK`
response, so the agent got broken HTTP connection for the call.
This patch introduces an acknowledgment for the received response
for the `ATTACH_CONTAINER_INPUT` call. This acknowledgment is a new
type of control messages for the `ATTACH_CONTAINER_INPUT` call. When
IOSwitchboard receives an acknowledgment, and io redirects are
finished, it terminates itself. That guarantees that the agent always
receives a response for the `ATTACH_CONTAINER_INPUT` call.


Diffs (updated)
-----

  include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 
  src/slave/containerizer/mesos/io/switchboard.cpp 52b0e521ed1c651c90b3a3df7c4df576288bf400

  src/slave/http.hpp 78200874cb03a3d5af4ee0443c03a1d94cd494cc 
  src/slave/http.cpp fb923686e92ff635e99cc2ccc6316f0282ab3e3a 


Diff: https://reviews.apache.org/r/65168/diff/2/

Changes: https://reviews.apache.org/r/65168/diff/1-2/


Testing
-------


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message