mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68619: Defaulted support scripts to Python 3.
Date Tue, 04 Sep 2018 17:21:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68619/#review208316
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Sept. 4, 2018, 4:41 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68619/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2018, 4:41 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Kevin Klues.
> 
> 
> Bugs: MESOS-8770
>     https://issues.apache.org/jira/browse/MESOS-8770
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use the new Python 3 support scripts by default, removing the deprecated
> ones using Python 2. The new scripts offer feature-parity and more, they
> require Python 3.6 or newer in order to run.
> 
> 
> Diffs
> -----
> 
>   docs/windows.md 2edab6dc0d982d106a1e1d8bb0ab9da3c3482390 
>   support/README.md 0eae4d36ae2531b6f44f2a2b5da863e1431e360a 
>   support/apply-reviews.py de22b7033a574562c59700914cde38cc5496d3e0 
>   support/build-virtualenv 90e1fc8210aa1cfc16ee9f28c4638193ef127849 
>   support/check-python3.py 898e5436ee2d0e2747a2720233fc13ec7c40f469 
>   support/generate-endpoint-help.py 8b38f739d544df64643d98ad8cfcaf9acbac4b87 
>   support/hooks/post-rewrite 81f345411e958aaffeca7d1b0a67d2bb561b1dad 
>   support/hooks/pre-commit ac0ff24b49846dc5d6d2bdd04b4ac861a8745805 
>   support/jsonurl.py c9cf1d99c4433315b69c4945423f985a85951d8d 
>   support/mesos-gtest-runner.py 9cabbdf901c8eb4df47b6b0ee46f48c56c0aa160 
>   support/mesos-split.py f83986db26dd640a8a91ec7a76c7a9ff69f61159 
>   support/mesos-style.py 7dbf96abd114c83a20d703e033943c38fa12b505 
>   support/pip-requirements.txt e3fbcc217827c480ab3b011a95973b67102a5bf7 
>   support/post-reviews.py 94ece857f15a8dc70680f226d1779bdfd11b50ff 
>   support/push-commits.py b10e802f8b6ff0307e21a34f31c7f11b31d521b0 
>   support/python3/apply-reviews.py 92ad85945fb97e6ae3e21b3b9ab53c885158417e 
>   support/python3/common.py  
>   support/python3/generate-endpoint-help.py 2db9e14b2749af958c714b4c4c1d8d1504fcafb0

>   support/python3/get-review-ids.py  
>   support/python3/jsonurl.py ffa3e362b31dcbbcbf4975d9bb41c074df4823b0 
>   support/python3/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
>   support/python3/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900 
>   support/python3/mesos-style.py c201038e99be88f5767fd0bdd0179186b566bef7 
>   support/python3/post-build-result.py  
>   support/python3/post-reviews.py feb7d51d2457912f9996049e6d36b58323456d12 
>   support/python3/push-commits.py 7be67e3b3756cd152b0d8b5eebaa0a032aab9a88 
>   support/python3/test-upgrade.py 3a7bcac3c1a9ed8c923b639394258fe02e346b4f 
>   support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb 
>   support/test-upgrade.py b7c66123b9fbd0b660186fa8667de0acaf8bcaab 
>   support/verify-reviews.py 3d8c67e0e161c24a25f0e89b34cef2099931038f 
> 
> 
> Diff: https://reviews.apache.org/r/68619/diff/1/
> 
> 
> Testing
> -------
> 
> This commit is mainly moving the files from `support/python3/` to `support/`. I have
fixed all the paths so that `support/python3` is not used anymore and replaced by `support/`.
I have tested `post-reviews.py` and `mesos-style.py` to post this review request.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message