mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68567: Restructured /roles code.
Date Tue, 04 Sep 2018 14:34:14 GMT


> On Sept. 4, 2018, 9:39 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 2648 (original), 2644 (patched)
> > <https://reviews.apache.org/r/68567/diff/1/?file=2079012#file2079012line2648>
> >
> >     `std::move()`

Reading https://www.ibm.com/developerworks/community/blogs/5894415f-be62-4bc0-81c5-3956e82276f3/entry/RVO_V_S_std_move?lang=en_us
it seems that casting to rvalue prevents compilers from doing NRVO => dropping.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68567/#review208297
-----------------------------------------------------------


On Sept. 4, 2018, 9:39 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68567/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2018, 9:39 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reworked the structure of the role handling in both
> v0 and v1 APIs in preparation for the subsequent commit.
> 
> As a nice bonus on top, this also saves one trip
> through the master queue for every call of this endpoint.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97 
>   src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b 
> 
> 
> Diff: https://reviews.apache.org/r/68567/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/68568/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message