mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.
Date Tue, 04 Sep 2018 10:11:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68601/#review208303
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/resource_provider/storage/provider.cpp
Lines 704 (patched)
<https://reviews.apache.org/r/68601/#comment292047>

    Nit: We capture `this` which is worth calling out.
    
        // ...
        .then(defer(self(), [this](
        // ...



src/resource_provider/storage/provider.cpp
Lines 731-734 (original), 739-742 (patched)
<https://reviews.apache.org/r/68601/#comment292045>

    Let's add this information to `getContainers`' docstring.



src/resource_provider/storage/provider.cpp
Lines 779-781 (patched)
<https://reviews.apache.org/r/68601/#comment292046>

    Since `killContainer` and `waitContainer` already handle not running containers, we should
simplify this flow by calling them unconditionally.
    
        Future<Nothing> cleanup = killContainer(containerId)
           .then(defer(self(), &Self::waitContainer, containerId)
           .then(defer(self(), [this, containerId, path]() -> Future<Nothing> {
           // ...



src/resource_provider/storage/provider.cpp
Lines 2083 (patched)
<https://reviews.apache.org/r/68601/#comment292048>

    Nit: `s/=/this/`


- Benjamin Bannier


On Sept. 4, 2018, 8:10 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68601/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2018, 8:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8429
>     https://issues.apache.org/jira/browse/MESOS-8429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a CSI plugin is crashed during agent failover, the residual socket
> file would exist during SLRP recovery, which may in turn make the plugin
> fail to restart. This patch cleans up the residual socket files to avoid
> such failures.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp ab1467c22ded269cb42fc52d3f00fb936fc42c7f

> 
> 
> Diff: https://reviews.apache.org/r/68601/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message