mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.
Date Tue, 04 Sep 2018 09:40:36 GMT


> On Aug. 30, 2018, 11:34 a.m., Benno Evers wrote:
> > src/master/readonly_handler.cpp
> > Lines 753 (patched)
> > <https://reviews.apache.org/r/68568/diff/1/?file=2079016#file2079016line753>
> >
> >     Note that this line had to be changed from `weights[name]` to `weights.at(name)`
during copying to make this compile as a const member function.

Thanks for calling this out!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208125
-----------------------------------------------------------


On Sept. 4, 2018, 9:39 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2018, 9:39 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-9194
>     https://issues.apache.org/jira/browse/MESOS-9194
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To improve consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97 
>   src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b 
>   src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069 
> 
> 
> Diff: https://reviews.apache.org/r/68568/diff/1/
> 
> 
> Testing
> -------
> 
> Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message