mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.
Date Mon, 03 Sep 2018 10:52:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68601/#review208250
-----------------------------------------------------------




src/authorizer/local/authorizer.cpp
Lines 1090 (patched)
<https://reviews.apache.org/r/68601/#comment291980>

    This should be a single patch 1.



src/authorizer/local/authorizer.cpp
Lines 1138 (patched)
<https://reviews.apache.org/r/68601/#comment291981>

    Patch 1.



src/internal/devolve.hpp
Lines 85 (patched)
<https://reviews.apache.org/r/68601/#comment291982>

    This should be a single patch 2.



src/internal/devolve.cpp
Lines 239-244 (patched)
<https://reviews.apache.org/r/68601/#comment291983>

    Patch 2.



src/resource_provider/storage/provider.cpp
Line 398 (original), 399 (patched)
<https://reviews.apache.org/r/68601/#comment291984>

    Patch 3.



src/resource_provider/storage/provider.cpp
Lines 701 (patched)
<https://reviews.apache.org/r/68601/#comment291986>

    I'd pull this down into the context making use of the value. Otherwise it isn't very clear
that `nodeContainerId` doesn't become unset between check and use.



src/resource_provider/storage/provider.cpp
Lines 760 (patched)
<https://reviews.apache.org/r/68601/#comment291987>

    Does this need to be specific to controller or node containers? I wonder if we could pull
it out of the conditional at l.740 to make this simpler, e.g., a structure
    
       (1) Cleanup dirs of exited containers
       (2) Special handling of up-to-date node/controller containers
       (3) Termination of other running containers.
       
    It would be great if (1) and (3) could share cleanup logic, but we don't have to do this
right now.



src/resource_provider/storage/provider.cpp
Line 770 (original), 805 (patched)
<https://reviews.apache.org/r/68601/#comment291988>

    Not your patch, but are we guaranteed to always remove the directory? What it the agent
crashes between the `killContainer` call and this line?



src/resource_provider/storage/provider.cpp
Lines 1950-1961 (patched)
<https://reviews.apache.org/r/68601/#comment291989>

    Could you add a comment why we do this here now instead of later?



src/resource_provider/storage/provider.cpp
Line 2054 (original), 2078 (patched)
<https://reviews.apache.org/r/68601/#comment291985>

    Patch 3.



src/resource_provider/storage/provider.cpp
Line 2093 (original), 2163 (patched)
<https://reviews.apache.org/r/68601/#comment291990>

    I am not sure how this is related. Is this a patch 4?



src/slave/http.cpp
Line 2235 (original), 2235 (patched)
<https://reviews.apache.org/r/68601/#comment291991>

    Patch 1?


- Benjamin Bannier


On Sept. 3, 2018, 2:44 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68601/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2018, 2:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8429
>     https://issues.apache.org/jira/browse/MESOS-8429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a CSI plugin is crashed during agent failover, the residual socket
> file would exist during SLRP recovery, which may in turn make the plugin
> fail to restart. This patch cleans up the residual socket files to avoid
> such failures.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b 
>   src/internal/devolve.hpp 1bc2a32e70600c785660d0b1d5d63378ffe344cc 
>   src/internal/devolve.cpp 93bd975b648888a9d83e34f4d7420b3b49f06d1f 
>   src/resource_provider/storage/provider.cpp ab1467c22ded269cb42fc52d3f00fb936fc42c7f

>   src/slave/http.cpp d0f6e1c5ffcc22cd280c64b20473f279ab4c14cc 
> 
> 
> Diff: https://reviews.apache.org/r/68601/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message