mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68604: Wrapped syscall initgroups by warning suppression pragma.
Date Sun, 02 Sep 2018 20:20:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68604/#review208240
-----------------------------------------------------------


Fix it, then Ship it!




LGTM! Thanks for fixing this Till. This was a very noisy warning.


3rdparty/stout/include/stout/os/posix/su.hpp
Lines 264-266 (original), 270-273 (patched)
<https://reviews.apache.org/r/68604/#comment291967>

    If I remove this block completely, not stout tests would fail on macos-10.13.6. Could
you create a tech debt ticket to add a test (maybe for stout's `setgroups` in general)?


- Benjamin Bannier


On Sept. 2, 2018, 10 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68604/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2018, 10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gilbert Song.
> 
> 
> Bugs: MESOS-8457
>     https://issues.apache.org/jira/browse/MESOS-8457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Wrapped syscall initgroups by warning suppression pragma.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/su.hpp 715f88852012b0efbc5dff38307a23175b2ff95f

> 
> 
> Diff: https://reviews.apache.org/r/68604/diff/1/
> 
> 
> Testing
> -------
> 
> Built on macOS 10.14 using Apple LLVM version 10.0.0 (clang-1000.10.43.1)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message