From reviews-return-81377-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 24 05:19:18 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9E941F296 for ; Fri, 24 Aug 2018 05:19:18 +0000 (UTC) Received: (qmail 41989 invoked by uid 500); 24 Aug 2018 05:19:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41952 invoked by uid 500); 24 Aug 2018 05:19:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41936 invoked by uid 99); 24 Aug 2018 05:19:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2018 05:19:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id ADED21A1099; Fri, 24 Aug 2018 05:19:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id l9s-ejxhKT3k; Fri, 24 Aug 2018 05:19:13 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8EA395F1E2; Fri, 24 Aug 2018 05:19:12 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2D42FE0101; Fri, 24 Aug 2018 05:19:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 030DFC40364; Fri, 24 Aug 2018 05:19:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3261820547726877544==" MIME-Version: 1.0 Subject: Re: Review Request 68495: Made command check always waits before removing the nested container. From: Mesos Reviewbot To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Alexander Rukletsov Cc: Mesos Reviewbot , Qian Zhang , mesos Date: Fri, 24 Aug 2018 05:19:11 -0000 Message-ID: <20180824051911.48078.79925@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68495/ X-Sender: Mesos Reviewbot References: <20180824025034.48077.42272@reviews-vm2.apache.org> In-Reply-To: <20180824025034.48077.42272@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============3261820547726877544== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review207850 ----------------------------------------------------------- Patch looks great! Reviews applied: [68495] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 24, 2018, 10:50 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68495/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2018, 10:50 a.m.) > > > Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Gilbert Song. > > > Bugs: MESOS-8568 > https://issues.apache.org/jira/browse/MESOS-8568 > > > Repository: mesos > > > Description > ------- > > Made command check always waits before removing the nested container. > > > Diffs > ----- > > src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678 > > > Diff: https://reviews.apache.org/r/68495/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > > --===============3261820547726877544==--