From reviews-return-80939-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 15 13:53:05 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07AAA18177 for ; Wed, 15 Aug 2018 13:53:05 +0000 (UTC) Received: (qmail 77785 invoked by uid 500); 15 Aug 2018 13:53:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 77756 invoked by uid 500); 15 Aug 2018 13:53:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77419 invoked by uid 99); 15 Aug 2018 13:53:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Aug 2018 13:53:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D29E8C6ABF; Wed, 15 Aug 2018 13:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.951 X-Spam-Level: X-Spam-Status: No, score=0.951 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id bY4KGglrLcnb; Wed, 15 Aug 2018 13:53:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 671025F19A; Wed, 15 Aug 2018 13:53:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1F165E1013; Wed, 15 Aug 2018 13:53:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0BCF8C4010E; Wed, 15 Aug 2018 13:53:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3370705102761035641==" MIME-Version: 1.0 Subject: Re: Review Request 68146: Added actions and ACLs to authorize removal of resource providers. From: Benjamin Bannier To: Chun-Hung Hsiao , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Wed, 15 Aug 2018 13:53:02 -0000 Message-ID: <20180815135302.29056.62701@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68146/ X-Sender: Benjamin Bannier References: <20180801154739.53842.55164@reviews-vm2.apache.org> In-Reply-To: <20180801154739.53842.55164@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============3370705102761035641== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68146/ ----------------------------------------------------------- (Updated Aug. 15, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Changes ------- Addressed issues raised by Chun. Bugs: MESOS-8403 https://issues.apache.org/jira/browse/MESOS-8403 Repository: mesos Description ------- Added actions and ACLs to authorize removal of resource providers. Diffs (updated) ----- include/mesos/authorizer/acls.proto f5d2580c29df5c9917a5ce0d5df876b3511438df include/mesos/authorizer/authorizer.proto 7330416b44ea12009362c1aae7935b079822efe1 src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b src/tests/authorization_tests.cpp de57fc97addee4bab9eafae6109a72cbb0c2f4ce Diff: https://reviews.apache.org/r/68146/diff/3/ Changes: https://reviews.apache.org/r/68146/diff/2-3/ Testing ------- `make check` Additional testing with the test case added in https://reviews.apache.org/r/68147/. Thanks, Benjamin Bannier --===============3370705102761035641==--