mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.
Date Fri, 31 Aug 2018 19:30:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68576/#review208194
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Aug. 31, 2018, 7:43 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68576/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2018, 7:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9193
>     https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch imports the `AX_APPEND_COMPILE_FLAGS` macro and its dependent
> `AX_REQUIRE_DEFINED` and `AX_APPEND_FLAG` macros to Autotools, and used
> the macro to add `-Wno-unused-local-typedef` for Clang 3.6.
> 
> The macros are retrieved from the following repository:
> https://git.savannah.gnu.org/git/autoconf-archive.git
> The `ax_append_compile_flags.m4` and `ax_required_defined.m4` macros are
> retrieved from the HEAD (`4dfd2f8`) at the time; the `ax_append_flag.m4`
> macro is retrieved from commit `3e4a839` to support Autoconf 2.59+.
> 
> NOTE: CentOS 6 uses Autoconf 2.63 and Ubuntu 14.04 uses 2.59.
> 
> 
> Diffs
> -----
> 
>   configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 
>   m4/ax_append_compile_flags.m4 PRE-CREATION 
>   m4/ax_append_flag.m4 PRE-CREATION 
>   m4/ax_require_defined.m4 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68576/diff/4/
> 
> 
> Testing
> -------
> 
> make check with clang 3.5.0/3.6.0/3.9.0/5.0.1.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message