mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68577: Stout: Fixed standalone build with libarchive.
Date Fri, 31 Aug 2018 18:46:57 GMT


> On Aug. 31, 2018, 9:50 a.m., Benjamin Bannier wrote:
> > Thanks for fixing this.
> > 
> > I confirmed that `make check` works in standalone `stout` builds now. Unfortunately
`make distcheck` still fails though.

Spend a bit time on `make distcheck`. There seems to be two issues:
1. Missing `$(BUNDLED_DIR)/` in `EXTRA_DIST`.
2. Failure to create `ar-lib`, possibly due to the fact that we hard-code the path for bundled
dir to be a relative path for `$(top_srcdir)`, which changes in `make distcheck`.
I'm not going to spend much time on this for now. Created https://issues.apache.org/jira/browse/MESOS-9200
to track this issue.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68577/#review208162
-----------------------------------------------------------


On Aug. 30, 2018, 9:07 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68577/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2018, 9:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, John Kordich, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9193
>     https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Fixed standalone build with libarchive.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/3rdparty/Makefile.am f51d7a00a06e02f184005f9af7d1f6504e1db949 
>   3rdparty/stout/configure.ac 5de0eb02cc3270071d64bbd92f566df620ad046e 
> 
> 
> Diff: https://reviews.apache.org/r/68577/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message