mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68564: Set up `-Wno-inconsistent-missing-override` conditionally.
Date Fri, 31 Aug 2018 17:46:17 GMT


> On Aug. 31, 2018, 11:36 a.m., Benjamin Bannier wrote:
> > configure.ac
> > Lines 639 (patched)
> > <https://reviews.apache.org/r/68564/diff/3/?file=2079131#file2079131line639>
> >
> >     If you implement https://reviews.apache.org/r/68576/#comment291938 this would
be another candidate to be moved to a more general place. The code here should be robust enough
to support that.

Dropping since the flag names are different between GCC and Clang.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68564/#review208169
-----------------------------------------------------------


On Aug. 30, 2018, 9:11 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68564/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2018, 9:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9193
>     https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clang 3.5 does not support `-Wno-inconsisent-missing-override` so we
> only add it if the tool chain supports this option.
> 
> 
> Diffs
> -----
> 
>   configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 
> 
> 
> Diff: https://reviews.apache.org/r/68564/diff/3/
> 
> 
> Testing
> -------
> 
> make with clang 3.5.0/3.6.0.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message