mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.
Date Fri, 31 Aug 2018 17:42:06 GMT


> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote:
> > m4/ax_append_compile_flags.m4
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/68576/diff/3/?file=2079149#file2079149line1>
> >
> >     Let's use the file from upstream `HEAD`, e.g., from `4dfd2f87b4dda8e8a7e1fb7714a9dae66b8badb4`.
> 
> Chun-Hung Hsiao wrote:
>     We couldn't use the upstream `HEAD` since it requires Autoconf 2.64, which is not
the default on CentOS 6 (2.63) and Ubuntu 14.04 (2.59). Based on an offline discussion, I'll
pick the latest commit that supports 2.59, namely `3e4a8395a33db74da6ed7b99a561bf7e4d2b06b3`,
unless you think that we don't need to maintain version consistency between these three files.
> 
> Chun-Hung Hsiao wrote:
>     Hmm there's actually no difference between `3e4a839` and `34f9151` so I'll just update
the commit message.

After discussion, I'll take your suggestion to use the latest macros except for `ax_append_flag.m4`.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68576/#review208165
-----------------------------------------------------------


On Aug. 31, 2018, 5:27 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68576/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2018, 5:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9193
>     https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch imports the `AX_APPEND_COMPILE_FLAGS` macro and its dependent
> `AX_REQUIRE_DEFINED` and `AX_APPEND_FLAG` macros to Autotools, and used
> the macro to add `-Wno-unused-local-typedef` for Clang 3.6.
> 
> The macros are retrieved from the following repository with commit
> `3e4a839` to support Autoconf 2.59+:
> http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=tree;f=m4;hb=3e4a839
> 
> 
> Diffs
> -----
> 
>   configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 
>   m4/ax_append_compile_flags.m4 PRE-CREATION 
>   m4/ax_append_flag.m4 PRE-CREATION 
>   m4/ax_require_defined.m4 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68576/diff/3/
> 
> 
> Testing
> -------
> 
> make check with clang 3.5.0/3.6.0/3.9.0/5.0.1.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message