mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.
Date Fri, 31 Aug 2018 17:27:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68576/
-----------------------------------------------------------

(Updated Aug. 31, 2018, 5:27 p.m.)


Review request for mesos, Benjamin Bannier and James Peach.


Changes
-------

Updated the macros with the latest commit supporting Autoconf 2.59.


Bugs: MESOS-9193
    https://issues.apache.org/jira/browse/MESOS-9193


Repository: mesos


Description (updated)
-------

This patch imports the `AX_APPEND_COMPILE_FLAGS` macro and its dependent
`AX_REQUIRE_DEFINED` and `AX_APPEND_FLAG` macros to Autotools, and used
the macro to add `-Wno-unused-local-typedef` for Clang 3.6.

The macros are retrieved from the following repository with tag
`v2014.10.15` to support Autoconf 2.59+:
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=tree;f=m4;hb=3e4a839


Diffs
-----

  configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 
  m4/ax_append_compile_flags.m4 PRE-CREATION 
  m4/ax_append_flag.m4 PRE-CREATION 
  m4/ax_require_defined.m4 PRE-CREATION 


Diff: https://reviews.apache.org/r/68576/diff/3/


Testing
-------

make check with clang 3.5.0/3.6.0/3.9.0/5.0.1.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message