mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 68586: Add the output file to the hash on CommandInfo::URI.
Date Fri, 31 Aug 2018 16:47:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68586/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Joseph Wu.


Bugs: MESOS-9172
    https://issues.apache.org/jira/browse/MESOS-9172


Repository: mesos


Description
-------

The `output_file` field of the `CommandInfo::URI` is not combined
into the hash value. This means that the fetcher does not consider two
messages that differ only by the `output_file` as different. By adding
the `output_file` to the hash it is possible for a task to fetch the
same URI to multiple, distinct ouptuts.


Diffs
-----

  include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa 
  include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb 


Diff: https://reviews.apache.org/r/68586/diff/1/


Testing
-------

make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message