mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68564: Disabled the `-Wunknown-warning-option` warnings for Clang 3.5.
Date Thu, 30 Aug 2018 15:34:53 GMT


> On Aug. 30, 2018, 6:12 a.m., Benjamin Bannier wrote:
> > configure.ac
> > Lines 656 (patched)
> > <https://reviews.apache.org/r/68564/diff/1/?file=2078977#file2078977line656>
> >
> >     Instead of ignoring unknown warnings altogether we should check whether the
current compiler supports `-Wno-inconsistent-missing-override`. See the test for `-Wno-unused-local-typedef`
above.

Consider using [ax_append_compile_flags](https://www.gnu.org/software/autoconf-archive/ax_append_compile_flags.html#ax_append_compile_flags)?


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68564/#review208120
-----------------------------------------------------------


On Aug. 30, 2018, 4:31 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68564/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2018, 4:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9193
>     https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clang 3.5 does not support `-Wno-inconsisent-missing-override` so we
> have to suppress `-Wunknown-warning-option` warnings if `-Werror` is on.
> 
> 
> Diffs
> -----
> 
>   configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 
> 
> 
> Diff: https://reviews.apache.org/r/68564/diff/1/
> 
> 
> Testing
> -------
> 
> make with clang 3.5.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message