mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.
Date Tue, 28 Aug 2018 19:48:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208060
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 28, 2018, 2:02 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68537/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2018, 2:02 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit fixes several minor style issues:
>  - Sorted member function declarations of `ReadOnlyHandler`
>    alphabetically.
>  - Added notes to remind readers of the fact that requests
>    to certain endpoints are batched.
>  - Changed captured variable in `/frameworks` endpoint handler.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 
>   src/master/readonly_handler.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68537/diff/2/
> 
> 
> Testing
> -------
> 
> Started Internal CI Run (Jenkins Id #4264)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message