mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 68543: Added stout helper to parse strings to protobuf messages.
Date Tue, 28 Aug 2018 18:29:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68543/#review208056
-----------------------------------------------------------




3rdparty/stout/include/stout/protobuf.hpp
Lines 778 (patched)
<https://reviews.apache.org/r/68543/#comment291801>

    Using `flags::parse` will include some deprecated behavior (if the string starts with
`"/"`, we will attempt to read a location on disk).  `JSON::parse<JSON::Object>` would
be a better choice.


- Joseph Wu


On Aug. 28, 2018, 10:25 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68543/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2018, 10:25 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stout helper to parse strings to protobuf messages.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b

>   3rdparty/stout/tests/protobuf_tests.cpp 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5 
> 
> 
> Diff: https://reviews.apache.org/r/68543/diff/1/
> 
> 
> Testing
> -------
> 
> New test passes.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message