mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68542: De-duplicated identical read-only requests to master.
Date Tue, 28 Aug 2018 17:07:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68542/#review208052
-----------------------------------------------------------



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68542`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2251/mesos-review-68542

Relevant logs:

- [apply-review-68542.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2251/mesos-review-68542/logs/apply-review-68542.log):

```
´╗┐error: patch failed: src/master/http.cpp:2383
error: src/master/http.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Aug. 28, 2018, 4:54 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68542/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2018, 4:54 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Under certain assumptions, we can safely assume that
> two requests with the same parametesr to the same endpoint
> will return the same result. This is most noticeable for
> the `/state` endpoint.
> 
> In this case, we only need to compute the response once.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 
> 
> 
> Diff: https://reviews.apache.org/r/68542/diff/1/
> 
> 
> Testing
> -------
> 
> Accessed `localhost:5050/state` on master including these changes.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message