mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68235: Cleaned up container on launch failures in composing containerizer.
Date Tue, 28 Aug 2018 14:46:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68235/#review208040
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 27, 2018, 2:57 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68235/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.
> 
> 
> Bugs: MESOS-9185
>     https://issues.apache.org/jira/browse/MESOS-9185
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, if a parent container was unknown to the composing
> containerizer during an attempt to launch a nested container
> via `ComposingContainerizerProcess::launch()`, the composing
> containerizer returned an error without cleaning up the container.
> The `containerizer` field was uninitialized, so a further attempt
> to remove or destroy the nested container led to segfault.
> 
> This patch removes the container when the parent container is unknown.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 521645839b422d455da08ce7ab306f83da0b88ad 
> 
> 
> Diff: https://reviews.apache.org/r/68235/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> This test fixes agent's segfault when running `AgentAPITest.LaunchNestedContainerWithUnknownParent`
test, which can be found in the previous patch.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message