mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.
Date Tue, 28 Aug 2018 10:30:30 GMT


> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Lines 2525 (patched)
> > <https://reviews.apache.org/r/68441/diff/1/?file=2075655#file2075655line2525>
> >
> >     Let's fix this inconsistency and pass `request.url.query.get("jsonp")` directly
like you do with all other handlers.

Fixed in https://reviews.apache.org/r/68537/


> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Lines 2528 (patched)
> > <https://reviews.apache.org/r/68441/diff/1/?file=2075655#file2075655line2528>
> >
> >     `return std::move(OK(...));`

Dropping this since we agreed in offline discussions that it would not make a difference.


> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp
> > Lines 1491-1492 (original), 1496-1497 (patched)
> > <https://reviews.apache.org/r/68441/diff/1/?file=2075656#file2075656line1496>
> >
> >     // NOTE: Requests to this endpoint are batched.
> >     
> >     Or maybe even better: group batched endpoints together.

Fixed in https://reviews.apache.org/r/68537/


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68441/#review207960
-----------------------------------------------------------


On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68441/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added '/slaves' to the set of batched master endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
> 
> 
> Diff: https://reviews.apache.org/r/68441/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message