mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 68400: Exposed an XFS helper to find the block device for a given path.
Date Tue, 28 Aug 2018 00:18:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68400/#review208010
-----------------------------------------------------------


Ship it!




Ship It!

- Ilya Pronin


On Aug. 24, 2018, 4:25 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68400/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang
Yan Xu.
> 
> 
> Bugs: MESOS-5158
>     https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To manage persistent volumes in the `disk/xfs` isolator we need
> to keep track of the block device that hosts a given filesystem
> path. Expose the `getDeviceForPath` helper API to directly return
> this information.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp e269eb5489ceed8937775a30b3420f7960ab4cd4

>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp b691c76e94f686e1a866380dca99ef0fa18e2f49

>   src/tests/containerizer/xfs_quota_tests.cpp 59ec182c1c3af3978156044f03d9e3d784d51fce

> 
> 
> Diff: https://reviews.apache.org/r/68400/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message