mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 68398: Added `fs::used` helper API to stout.
Date Mon, 27 Aug 2018 23:26:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68398/#review208007
-----------------------------------------------------------


Fix it, then Ship it!




LGTM! Only 1 minor comment about the new test.


3rdparty/stout/tests/os_tests.cpp
Lines 1157-1164 (patched)
<https://reviews.apache.org/r/68398/#comment291726>

    What if current directory is a different partition than `/`?


- Ilya Pronin


On Aug. 24, 2018, 4:24 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68398/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang
Yan Xu.
> 
> 
> Bugs: MESOS-5158
>     https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a `fs::used` API that returns the amount of used space on a
> given filesystem.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/fs.hpp 269a4f50f1df8d68be9e11030f885cf2c254c9d8

>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68398/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message