mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.
Date Mon, 27 Aug 2018 21:29:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/
-----------------------------------------------------------

(Updated Aug. 27, 2018, 2:29 p.m.)


Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Changes
-------

Fixed build break.


Bugs: MESOS-5813
    https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
-------

These tests were (partially) ported by implementing logic similar to
the what's used on POSIX with `os::Fork` and `os::Exec` (which will
not be implemented on Windows).


Diffs (updated)
-----

  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68532/diff/2/

Changes: https://reviews.apache.org/r/68532/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message