mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radhika Jandhyala via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68531: Windows: Ported `OsTest.Environment`.
Date Mon, 27 Aug 2018 21:17:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68531/#review207995
-----------------------------------------------------------


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:15 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68531/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2018, 9:15 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
>     https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This required replacing `os::raw::environment()` inline as it does not
> exist on Windows. Furthermore, it was also discovered that the
> documentation is incorrect, and that sometimes environment variables
> start with an equal sign. The fix is to simply look for the first
> equal sign excluding the first character, otherwise we end up with
> empty keys.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/environment.hpp 40eee59ac0b73ebe71b120e540ba7eace672ff4c

>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68531/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message