-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68495/#review207984
-----------------------------------------------------------
src/checks/checker_process.cpp
Lines 878-889 (original), 890-901 (patched)
<https://reviews.apache.org/r/68495/#comment291705>
It looks like we should always call `waitNestedContainer()` after we said `previousCheckContainerId
= checkContainerId;`. For example here.
Maybe it makes sense to call `waitNestedContainer()` right in the beginning? We can end
up calling it twice, but I think it's fine?
- Alexander Rukletsov
On Aug. 24, 2018, 9:54 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68495/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 9:54 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, and Gilbert
Song.
>
>
> Bugs: MESOS-8568
> https://issues.apache.org/jira/browse/MESOS-8568
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made command check always waits before removing the nested container.
>
>
> Diffs
> -----
>
> src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678
>
>
> Diff: https://reviews.apache.org/r/68495/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
|